mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-04-04 19:26:58 +00:00
[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)
Address issues reported by ruff check (#11043)
* Resolve E713 and E714 (not in/is tests).
* Address UP018 (unnecessary str call).
* UP045 requires Python 3.10+.
* Address UP007 (X | Y for type annotations).
* Address UP035 (import Callable from collections.abc).
* Address UP006 (t.Dict -> dict).
* Address UP009 (UTF-8 encoding comment).
* Address UP034 (extraneous parantheses).
* Address SIM910 (dict.get() with None default).
* Address F401 (unused import).
* Address UP020 (use builtin open).
* Address B009 and B010 (getattr/setattr with constant name).
* Address SIM300 (Yoda conditions).
* UP029 isn't in use anyway.
* Address FLY002 (static join).
* Address B034 (re.sub positional args).
* Address B020 (loop variable overrides input).
* Address B017 (assert raise Exception).
* Address SIM211 (if expression with false/true).
* Address SIM113 (enumerate for loop).
* Address UP036 (sys.version_info checks).
* Remove unnecessary UP039.
* Address SIM201 (not ==).
* Address SIM212 (if expr with twisted arms).
* Add changelog fragment.
* Reformat.
(cherry picked from commit 3478863ef0)
Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
parent
11b802372b
commit
16f1d07509
77 changed files with 196 additions and 222 deletions
|
|
@ -271,11 +271,11 @@ class GitlabIssue:
|
|||
for key, value in options.items():
|
||||
if value is not None:
|
||||
if key == "milestone_id":
|
||||
old_milestone = getattr(issue, "milestone")["id"] if getattr(issue, "milestone") else ""
|
||||
old_milestone = issue.milestone["id"] if issue.milestone else ""
|
||||
if value != old_milestone:
|
||||
return True
|
||||
elif key == "assignee_ids":
|
||||
if value != sorted([user["id"] for user in getattr(issue, "assignees")]):
|
||||
if value != sorted([user["id"] for user in issue.assignees]):
|
||||
return True
|
||||
|
||||
elif key == "labels":
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue