ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-04-07 04:27:15 +00:00
Code Activity

[PR #11043/3478863e backport][stable-12] Address issues reported by ruff check (#11047)

Browse source 
Address issues reported by ruff check (#11043)

* Resolve E713 and E714 (not in/is tests).

* Address UP018 (unnecessary str call).

* UP045 requires Python 3.10+.

* Address UP007 (X | Y for type annotations).

* Address UP035 (import Callable from collections.abc).

* Address UP006 (t.Dict -> dict).

* Address UP009 (UTF-8 encoding comment).

* Address UP034 (extraneous parantheses).

* Address SIM910 (dict.get() with None default).

* Address F401 (unused import).

* Address UP020 (use builtin open).

* Address B009 and B010 (getattr/setattr with constant name).

* Address SIM300 (Yoda conditions).

* UP029 isn't in use anyway.

* Address FLY002 (static join).

* Address B034 (re.sub positional args).

* Address B020 (loop variable overrides input).

* Address B017 (assert raise Exception).

* Address SIM211 (if expression with false/true).

* Address SIM113 (enumerate for loop).

* Address UP036 (sys.version_info checks).

* Remove unnecessary UP039.

* Address SIM201 (not ==).

* Address SIM212 (if expr with twisted arms).

* Add changelog fragment.

* Reformat.

(cherry picked from commit 3478863ef0)

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
patchback[bot] 2025-11-08 09:49:52 +01:00 • committed by GitHub
parent 11b802372b
commit 16f1d07509
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
77 changed files with 196 additions and 222 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugins/modules/ali_instance.py
View file

@ -631,8 +631,8 @@ def get_instances_info(connection, ids):
if len(instances) > 0:
for inst in instances:
volumes = connection.describe_disks(instance_id=inst.id)
setattr(inst, "block_device_mappings", volumes)
setattr(inst, "user_data", inst.describe_user_data())
inst.block_device_mappings = volumes
inst.user_data = inst.describe_user_data()
result.append(inst.read())
return result
@ -748,7 +748,7 @@ def modify_instance(module, instance):
password = module.params["password"]
# userdata can be modified only when instance is stopped
setattr(instance, "user_data", instance.describe_user_data())
instance.user_data = instance.describe_user_data()
user_data = instance.user_data
if state == "stopped":
user_data = module.params["user_data"].encode()