ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-02-04 07:51:50 +00:00
Code Activity

Add support for multiple managers to get_manager_attributes command in idrac_redfish_info module (#11301)

Browse source 
* Update get_manager_attributes method to support systems with multiple managers present

Fixes https://github.com/ansible-collections/community.general/issues/11294

* Add changelog fragment
Pre-define reponse for get_manager_attributes method

* Update changelogs/fragments/11301-idrac-info-multi-manager.yml

Update per suggestion!

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/idrac_redfish_info.py
Remove extra manager quantity check

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Scott Seekamp 2026-01-02 09:58:49 -07:00 • committed by GitHub
parent 20ba59cce6
commit 13035e2a2c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
changelogs/fragments/11301-idrac-info-multi-manager.yml Normal file
View file

@ -0,0 +1,2 @@
minor_changes:
- idrac_redfish_info - add multiple manager support to ``GetManagerAttributes`` command (https://github.com/ansible-collections/community.general/pull/11294).

6
plugins/modules/idrac_redfish_info.py
View file

@ -138,10 +138,14 @@ from ansible_collections.community.general.plugins.module_utils.redfish_utils im
class IdracRedfishUtils(RedfishUtils): class IdracRedfishUtils(RedfishUtils):
def get_manager_attributes(self): def get_manager_attributes(self):
result = {} result = {}
response = {}
manager_attributes = [] manager_attributes = []
properties = ["Attributes", "Id"] properties = ["Attributes", "Id"]
response = self.get_request(self.root_uri + self.manager_uri) if len(self.manager_uris) == 1:
response = self.get_request(f"{self.root_uri}{self.manager_uri}")
elif len(self.manager_uris) > 1:
response = self.get_request(f"{self.root_uri}/redfish/v1/Managers/iDRAC.Embedded.1", override_headers=None)
if response["ret"] is False: if response["ret"] is False:
return response return response