[stable-2] added supports_check_mode=True to info/facts modules (#3095)

* added supports_check_mode=True to info/facts modules (#3084)

* added supports_check_mode=True to info/facts modules

* added changelog fragment

* rolled back vertica_info

* rolled back utm_proxy_*_info

* updated changelog fragment with latest adjustments

* Update changelogs/fragments/3084-info-checkmode.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* added check mode to xenserver_facts + oneview_*_info

* added check mode to utm_proxy_*_info

* updated changelog

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7da2c16b4a)

* Also fix modules removed in 3.0.0.

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

plugins/modules/remote_management/dellemc/ome_device_info.py

@@ -374,7 +374,7 @@ def main():
         },
         required_if=[['fact_subset', 'detailed_inventory', ['system_query_options']],
                      ['fact_subset', 'subsystem_health', ['system_query_options']], ],
-        supports_check_mode=False)
+        supports_check_mode=True)
 
     try:
         _validate_inputs(module.params)

plugins/modules/remote_management/oneview/oneview_datacenter_info.py

@@ -116,7 +116,10 @@ class DatacenterInfoModule(OneViewModuleBase):
     )
 
     def __init__(self):
-        super(DatacenterInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
+        super(DatacenterInfoModule, self).__init__(
+            additional_arg_spec=self.argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_datacenter_facts', 'community.general.oneview_datacenter_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_datacenter_facts' module has been renamed to 'oneview_datacenter_info', "

plugins/modules/remote_management/oneview/oneview_enclosure_info.py

@@ -163,7 +163,10 @@ class EnclosureInfoModule(OneViewModuleBase):
     )
 
     def __init__(self):
-        super(EnclosureInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
+        super(EnclosureInfoModule, self).__init__(
+            additional_arg_spec=self.argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_enclosure_facts', 'community.general.oneview_enclosure_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_enclosure_facts' module has been renamed to 'oneview_enclosure_info', "

plugins/modules/remote_management/oneview/oneview_ethernet_network_info.py

@@ -114,7 +114,10 @@ class EthernetNetworkInfoModule(OneViewModuleBase):
     )
 
     def __init__(self):
-        super(EthernetNetworkInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
+        super(EthernetNetworkInfoModule, self).__init__(
+            additional_arg_spec=self.argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_ethernet_network_facts', 'community.general.oneview_ethernet_network_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_ethernet_network_facts' module has been renamed to 'oneview_ethernet_network_info', "

plugins/modules/remote_management/oneview/oneview_fc_network_info.py

@@ -83,7 +83,10 @@ class FcNetworkInfoModule(OneViewModuleBase):
             params=dict(required=False, type='dict')
         )
 
-        super(FcNetworkInfoModule, self).__init__(additional_arg_spec=argument_spec)
+        super(FcNetworkInfoModule, self).__init__(
+            additional_arg_spec=argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_fc_network_facts', 'community.general.oneview_fc_network_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_fc_network_facts' module has been renamed to 'oneview_fc_network_info', "

plugins/modules/remote_management/oneview/oneview_fcoe_network_info.py

@@ -82,7 +82,10 @@ class FcoeNetworkInfoModule(OneViewModuleBase):
             params=dict(type='dict'),
         )
 
-        super(FcoeNetworkInfoModule, self).__init__(additional_arg_spec=argument_spec)
+        super(FcoeNetworkInfoModule, self).__init__(
+            additional_arg_spec=argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_fcoe_network_facts', 'community.general.oneview_fcoe_network_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_fcoe_network_facts' module has been renamed to 'oneview_fcoe_network_info', "

plugins/modules/remote_management/oneview/oneview_logical_interconnect_group_info.py

@@ -96,7 +96,10 @@ class LogicalInterconnectGroupInfoModule(OneViewModuleBase):
             params=dict(type='dict'),
         )
 
-        super(LogicalInterconnectGroupInfoModule, self).__init__(additional_arg_spec=argument_spec)
+        super(LogicalInterconnectGroupInfoModule, self).__init__(
+            additional_arg_spec=argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_logical_interconnect_group_facts', 'community.general.oneview_logical_interconnect_group_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_logical_interconnect_group_facts' module has been renamed to 'oneview_logical_interconnect_group_info', "

plugins/modules/remote_management/oneview/oneview_network_set_info.py

@@ -135,7 +135,10 @@ class NetworkSetInfoModule(OneViewModuleBase):
     )
 
     def __init__(self):
-        super(NetworkSetInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
+        super(NetworkSetInfoModule, self).__init__(
+            additional_arg_spec=self.argument_spec,
+            supports_check_mode=True,
+        )
         self.is_old_facts = self.module._name in ('oneview_network_set_facts', 'community.general.oneview_network_set_facts')
         if self.is_old_facts:
             self.module.deprecate("The 'oneview_network_set_facts' module has been renamed to 'oneview_network_set_info', "

plugins/modules/remote_management/oneview/oneview_san_manager_info.py

@@ -90,7 +90,10 @@ class SanManagerInfoModule(OneViewModuleBase):
     )
 
     def __init__(self):
-        super(SanManagerInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
+        super(SanManagerInfoModule, self).__init__(
+            additional_arg_spec=self.argument_spec,
+            supports_check_mode=True,
+        )
         self.resource_client = self.oneview_client.san_managers
         self.is_old_facts = self.module._name in ('oneview_san_manager_facts', 'community.general.oneview_san_manager_facts')
         if self.is_old_facts:

plugins/modules/remote_management/redfish/idrac_redfish_info.py

@@ -191,7 +191,7 @@ def main():
         mutually_exclusive=[
             ('username', 'auth_token'),
         ],
-        supports_check_mode=False
+        supports_check_mode=True,
     )
     is_old_facts = module._name in ('idrac_redfish_facts', 'community.general.idrac_redfish_facts')
     if is_old_facts:

plugins/modules/remote_management/redfish/redfish_info.py

@@ -318,7 +318,7 @@ def main():
         mutually_exclusive=[
             ('username', 'auth_token'),
         ],
-        supports_check_mode=False
+        supports_check_mode=True,
     )
     is_old_facts = module._name in ('redfish_facts', 'community.general.redfish_facts')
     if is_old_facts: