[stable-2] added supports_check_mode=True to info/facts modules (#3095)

* added supports_check_mode=True to info/facts modules (#3084)

* added supports_check_mode=True to info/facts modules

* added changelog fragment

* rolled back vertica_info

* rolled back utm_proxy_*_info

* updated changelog fragment with latest adjustments

* Update changelogs/fragments/3084-info-checkmode.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* added check mode to xenserver_facts + oneview_*_info

* added check mode to utm_proxy_*_info

* updated changelog

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7da2c16b4a)

* Also fix modules removed in 3.0.0.

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>

plugins/modules/cloud/alicloud/ali_instance_info.py

@@ -382,7 +382,10 @@ def main():
         filters=dict(type='dict')
     )
     )
-    module = AnsibleModule(argument_spec=argument_spec)
+    module = AnsibleModule(
+        argument_spec=argument_spec,
+        supports_check_mode=True,
+    )
     if module._name in ('ali_instance_facts', 'community.general.ali_instance_facts'):
         module.deprecate("The 'ali_instance_facts' module has been renamed to 'ali_instance_info'",
                          version='3.0.0', collection_name='community.general')  # was Ansible 2.13

plugins/modules/cloud/memset/memset_memstore_info.py

@@ -149,7 +149,7 @@ def main():
             api_key=dict(required=True, type='str', no_log=True),
             name=dict(required=True, type='str')
         ),
-        supports_check_mode=False
+        supports_check_mode=True,
     )
     if module._name in ('memset_memstore_facts', 'community.general.memset_memstore_facts'):
         module.deprecate("The 'memset_memstore_facts' module has been renamed to 'memset_memstore_info'",

plugins/modules/cloud/memset/memset_server_info.py

@@ -274,7 +274,7 @@ def main():
             api_key=dict(required=True, type='str', no_log=True),
             name=dict(required=True, type='str')
         ),
-        supports_check_mode=False
+        supports_check_mode=True,
     )
     if module._name in ('memset_server_facts', 'community.general.memset_server_facts'):
         module.deprecate("The 'memset_server_facts' module has been renamed to 'memset_server_info'",

plugins/modules/cloud/misc/xenserver_facts.py

@@ -160,7 +160,9 @@ def get_srs(session):
 
 
 def main():
-    module = AnsibleModule({})
+    module = AnsibleModule(
+        supports_check_mode=True,
+    )
 
     if not HAVE_XENAPI:
         module.fail_json(changed=False, msg="python xen api required for this module")

plugins/modules/cloud/ovirt/ovirt_affinity_label_facts.py

@@ -127,7 +127,7 @@ def main():
         host=dict(default=None),
         vm=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_affinity_label_facts', 'community.general.ovirt_affinity_label_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_affinity_label_facts' module has been renamed to 'ovirt_affinity_label_info', "

plugins/modules/cloud/ovirt/ovirt_api_facts.py

@@ -63,7 +63,7 @@ from ansible_collections.community.general.plugins.module_utils._ovirt import (
 
 def main():
     argument_spec = ovirt_info_full_argument_spec()
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_api_facts', 'community.general.ovirt_api_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_api_facts' module has been renamed to 'ovirt_api_info', "

plugins/modules/cloud/ovirt/ovirt_cluster_facts.py

@@ -86,7 +86,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_cluster_facts', 'community.general.ovirt_cluster_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_cluster_facts' module has been renamed to 'ovirt_cluster_info', "

plugins/modules/cloud/ovirt/ovirt_datacenter_facts.py

@@ -69,7 +69,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_datacenter_facts', 'community.general.ovirt_datacenter_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_datacenter_facts' module has been renamed to 'ovirt_datacenter_info', "

plugins/modules/cloud/ovirt/ovirt_disk_facts.py

@@ -85,7 +85,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_disk_facts', 'community.general.ovirt_disk_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_disk_facts' module has been renamed to 'ovirt_disk_info', "

plugins/modules/cloud/ovirt/ovirt_event_facts.py

@@ -122,7 +122,7 @@ def main():
         query=dict(default='', required=False),
         wait=dict(default=True, type='bool', required=False)
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_event_facts', 'community.general.ovirt_event_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_event_facts' module has been renamed to 'ovirt_event_info', "

plugins/modules/cloud/ovirt/ovirt_external_provider_facts.py

@@ -116,7 +116,7 @@ def main():
             aliases=['provider'],
         ),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_external_provider_facts', 'community.general.ovirt_external_provider_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_external_provider_facts' module has been renamed to 'ovirt_external_provider_info', "

plugins/modules/cloud/ovirt/ovirt_group_facts.py

@@ -84,7 +84,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_group_facts', 'community.general.ovirt_group_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_group_facts' module has been renamed to 'ovirt_group_info', "

plugins/modules/cloud/ovirt/ovirt_host_facts.py

@@ -104,7 +104,7 @@ def main():
         all_content=dict(default=False, type='bool'),
         cluster_version=dict(default=None, type='str'),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_host_facts', 'community.general.ovirt_host_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_host_facts' module has been renamed to 'ovirt_host_info', "

plugins/modules/cloud/ovirt/ovirt_host_storage_facts.py

@@ -126,7 +126,7 @@ def main():
         iscsi=dict(default=None, type='dict'),
         fcp=dict(default=None, type='dict'),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_host_storage_facts', 'community.general.ovirt_host_storage_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_host_storage_facts' module has been renamed to 'ovirt_host_storage_info', "

plugins/modules/cloud/ovirt/ovirt_network_facts.py

@@ -86,7 +86,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_network_facts', 'community.general.ovirt_network_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_network_facts' module has been renamed to 'ovirt_network_info', "

plugins/modules/cloud/ovirt/ovirt_nic_facts.py

@@ -91,7 +91,7 @@ def main():
         vm=dict(required=True),
         name=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_nic_facts', 'community.general.ovirt_nic_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_nic_facts' module has been renamed to 'ovirt_nic_info', "

plugins/modules/cloud/ovirt/ovirt_permission_facts.py

@@ -128,7 +128,7 @@ def main():
         group_name=dict(default=None),
         namespace=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_permission_facts', 'community.general.ovirt_permission_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_permission_facts' module has been renamed to 'ovirt_permission_info', "

plugins/modules/cloud/ovirt/ovirt_quota_facts.py

@@ -91,7 +91,7 @@ def main():
         data_center=dict(required=True),
         name=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_quota_facts', 'community.general.ovirt_quota_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_quota_facts' module has been renamed to 'ovirt_quota_info', "

plugins/modules/cloud/ovirt/ovirt_scheduling_policy_facts.py

@@ -90,7 +90,7 @@ def main():
         id=dict(default=None),
         name=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_scheduling_policy_facts', 'community.general.ovirt_scheduling_policy_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_scheduling_policy_facts' module has been renamed to 'ovirt_scheduling_policy_info', "

plugins/modules/cloud/ovirt/ovirt_snapshot_facts.py

@@ -81,7 +81,7 @@ def main():
         description=dict(default=None),
         snapshot_id=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_snapshot_facts', 'community.general.ovirt_snapshot_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_snapshot_facts' module has been renamed to 'ovirt_snapshot_info', "

plugins/modules/cloud/ovirt/ovirt_storage_domain_facts.py

@@ -87,7 +87,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_storage_domain_facts', 'community.general.ovirt_storage_domain_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_storage_domain_facts' module has been renamed to 'ovirt_storage_domain_info', "

plugins/modules/cloud/ovirt/ovirt_storage_template_facts.py

@@ -95,7 +95,7 @@ def main():
         max=dict(default=None, type='int'),
         unregistered=dict(default=False, type='bool'),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_storage_template_facts', 'community.general.ovirt_storage_template_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_storage_template_facts' module has been renamed to 'ovirt_storage_template_info', "

plugins/modules/cloud/ovirt/ovirt_storage_vm_facts.py

@@ -95,7 +95,7 @@ def main():
         max=dict(default=None, type='int'),
         unregistered=dict(default=False, type='bool'),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_storage_vm_facts', 'community.general.ovirt_storage_vm_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_storage_vm_facts' module has been renamed to 'ovirt_storage_vm_info', "

plugins/modules/cloud/ovirt/ovirt_tag_facts.py

@@ -111,7 +111,7 @@ def main():
         host=dict(default=None),
         vm=dict(default=None),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_tag_facts', 'community.general.ovirt_tag_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_tag_facts' module has been renamed to 'ovirt_tag_info', "

plugins/modules/cloud/ovirt/ovirt_template_facts.py

@@ -85,7 +85,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_template_facts', 'community.general.ovirt_template_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_template_facts' module has been renamed to 'ovirt_template_info', "

plugins/modules/cloud/ovirt/ovirt_user_facts.py

@@ -84,7 +84,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_user_facts', 'community.general.ovirt_user_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_user_facts' module has been renamed to 'ovirt_user_info', "

plugins/modules/cloud/ovirt/ovirt_vm_facts.py

@@ -119,7 +119,7 @@ def main():
         case_sensitive=dict(default=True, type='bool'),
         max=dict(default=None, type='int'),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_vm_facts', 'community.general.ovirt_vm_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_vm_facts' module has been renamed to 'ovirt_vm_info', "

plugins/modules/cloud/ovirt/ovirt_vmpool_facts.py

@@ -84,7 +84,7 @@ def main():
     argument_spec = ovirt_info_full_argument_spec(
         pattern=dict(default='', required=False),
     )
-    module = AnsibleModule(argument_spec)
+    module = AnsibleModule(argument_spec, supports_check_mode=True)
     is_old_facts = module._name in ('ovirt_vmpool_facts', 'community.general.ovirt_vmpool_facts')
     if is_old_facts:
         module.deprecate("The 'ovirt_vmpool_facts' module has been renamed to 'ovirt_vmpool_info', "

plugins/modules/cloud/rackspace/rax_facts.py

@@ -124,6 +124,7 @@ def main():
         required_together=rax_required_together(),
         mutually_exclusive=[['address', 'id', 'name']],
         required_one_of=[['address', 'id', 'name']],
+        supports_check_mode=True,
     )
 
     if not HAS_PYRAX:

plugins/modules/cloud/smartos/smartos_image_info.py

@@ -100,7 +100,7 @@ def main():
         argument_spec=dict(
             filters=dict(default=None),
         ),
-        supports_check_mode=False,
+        supports_check_mode=True,
     )
     is_old_facts = module._name in ('smartos_image_facts', 'community.general.smartos_image_facts')
     if is_old_facts: