From 08442186e617519dffd31356f8589147216e2166 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Fri, 3 Apr 2026 14:37:48 +1300 Subject: [PATCH] xenserver_guest: fix code style caught by codeqa (#11721) * xenserver_guest: fix code style caught by codeqa * add changelog frag --- changelogs/fragments/11721-xenserver-guest-codeqa.yml | 2 ++ plugins/modules/xenserver_guest.py | 5 +---- 2 files changed, 3 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/11721-xenserver-guest-codeqa.yml diff --git a/changelogs/fragments/11721-xenserver-guest-codeqa.yml b/changelogs/fragments/11721-xenserver-guest-codeqa.yml new file mode 100644 index 0000000000..a28d885c96 --- /dev/null +++ b/changelogs/fragments/11721-xenserver-guest-codeqa.yml @@ -0,0 +1,2 @@ +minor_changes: + - xenserver_guest - use ``enumerate()`` instead of manual index variable in ``for`` loop (https://github.com/ansible-collections/community.general/pull/11721). diff --git a/plugins/modules/xenserver_guest.py b/plugins/modules/xenserver_guest.py index e17e042e0e..d61d85dd27 100644 --- a/plugins/modules/xenserver_guest.py +++ b/plugins/modules/xenserver_guest.py @@ -938,9 +938,7 @@ class XenServerVM(XenServerObject): )[0] self.xapi_session.xenapi.VBD.insert(cdrom_vbd_ref, cdrom_vdi_ref) elif change.get("networks_changed"): - position = 0 - - for network_change_list in change["networks_changed"]: + for position, network_change_list in enumerate(change["networks_changed"]): if network_change_list: vm_vif_params = self.vm_params["VIFs"][position] network_params = self.module.params["networks"][position] @@ -1113,7 +1111,6 @@ class XenServerVM(XenServerObject): network_params[network_change], ) - position += 1 elif change.get("networks_new"): for position, vif_device in change["networks_new"]: network_params = self.module.params["networks"][position]