From 011426701fc093058b3413c2bcdb05c2128234c7 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky Date: Sun, 22 Mar 2026 16:10:23 +1300 Subject: [PATCH] simplify the test --- .../integration/targets/python_runner/aliases | 20 -------------- .../targets/python_runner/files/settings.py | 9 ------- .../targets/python_runner/tasks/main.yml | 27 ++----------------- 3 files changed, 2 insertions(+), 54 deletions(-) delete mode 100644 tests/integration/targets/python_runner/files/settings.py diff --git a/tests/integration/targets/python_runner/aliases b/tests/integration/targets/python_runner/aliases index 061ccbaa91..2df23d823c 100644 --- a/tests/integration/targets/python_runner/aliases +++ b/tests/integration/targets/python_runner/aliases @@ -3,23 +3,3 @@ # SPDX-License-Identifier: GPL-3.0-or-later azp/posix/2 -skip/freebsd -skip/macos -skip/osx -skip/rhel8.2 -skip/rhel8.3 -skip/rhel8.4 -skip/rhel8.5 -skip/rhel8.6 -skip/rhel8.7 -skip/rhel8.8 -skip/rhel9.0 -skip/rhel9.1 -skip/rhel9.2 -skip/rhel9.3 -skip/rhel9.4 -skip/rhel9.5 -skip/rhel9.6 -skip/rhel9.7 -skip/rhel10.0 -skip/rhel10.1 diff --git a/tests/integration/targets/python_runner/files/settings.py b/tests/integration/targets/python_runner/files/settings.py deleted file mode 100644 index 85bbb00973..0000000000 --- a/tests/integration/targets/python_runner/files/settings.py +++ /dev/null @@ -1,9 +0,0 @@ -# Copyright (c) 2026, Alexei Znamensky -# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt) -# SPDX-License-Identifier: GPL-3.0-or-later - -SECRET_KEY = "test-secret-key-for-python-runner-integration-test-do-not-use-in-production" - -INSTALLED_APPS = [] - -DATABASES = {} diff --git a/tests/integration/targets/python_runner/tasks/main.yml b/tests/integration/targets/python_runner/tasks/main.yml index 27d917836a..d5e59f357c 100644 --- a/tests/integration/targets/python_runner/tasks/main.yml +++ b/tests/integration/targets/python_runner/tasks/main.yml @@ -24,38 +24,15 @@ state: present virtualenv: "{{ tmp_python_runner.path }}/venv" -- name: Copy settings file to temporary directory - ansible.builtin.copy: - src: settings.py - dest: "{{ tmp_python_runner.path }}/settings.py" - mode: "0644" - # Regression test for https://github.com/ansible-collections/community.general/issues/8884 # Bug: PythonRunner was setting path_prefix to a string instead of a list, corrupting PATH # when venv was specified, so the venv's python could not be found. -- name: Run django_command check using virtualenv (regression test for issue 8884) - community.general.django_command: - command: check - settings: settings - pythonpath: "{{ tmp_python_runner.path }}" - venv: "{{ tmp_python_runner.path }}/venv" - register: result_check - -- name: Assert django_command succeeded and returned a version - ansible.builtin.assert: - that: - - result_check is success - - result_check.version is defined - - result_check.version != "" - -# Second test: mirrors the scenario from issue 8884 — a real Django project created -# with django-admin startproject, then checked via django_command with a venv. # The original reporter was running `migrate`; we use `check` to avoid needing a database. - name: Create Django project using venv django-admin ansible.builtin.command: cmd: >- - {{ tmp_python_runner.path }}/venv/bin/django-admin startproject - testproject {{ tmp_python_runner.path }}/testproject + {{ tmp_python_runner.path }}/venv/bin/django-admin startproject testproject + chdir: {{ tmp_python_runner.path }} - name: Run django_command check on the created project (issue 8884 scenario) community.general.django_command: