ansible/ansible.posix
1
0
Fork 0
mirror of https://github.com/ansible-collections/ansible.posix.git synced 2026-02-03 23:51:48 +00:00
Code Activity

Merge pull request #484 from flowerysong/firewalld_offline

Browse source 
firewalld: make offline do something

SUMMARY

ansible.posix.firewalld has an offline flag, but it currently does not do anything. What most people expect it to do is allow the task to proceed even when firewalld is offline, so it makes the most sense for it to override the immediate flag and prevent the module from throwing an error in that case.
Fixes #81.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

firewalld
ADDITIONAL INFORMATION

Reviewed-by: Adam Miller <admiller@redhat.com>
This commit is contained in:
softwarefactory-project-zuul[bot] 2023-12-07 21:18:29 +00:00 • committed by GitHub
commit 2c52f969e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 40 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

8
tests/integration/targets/firewalld/tasks/service_test_cases.yml
View file

@ -21,6 +21,8 @@
ansible.posix.firewalld:
service: https
permanent: true
immediate: true
offline: true
state: enabled
register: result
@ -33,6 +35,8 @@
ansible.posix.firewalld:
service: https
permanent: true
immediate: true
offline: true
state: enabled
register: result
@ -45,6 +49,8 @@
ansible.posix.firewalld:
service: https
permanent: true
immediate: true
offline: true
state: disabled
register: result
@ -57,6 +63,8 @@
ansible.posix.firewalld:
service: https
permanent: true
immediate: true
offline: true
state: disabled
register: result