mirror of
https://github.com/containers/ansible-podman-collections.git
synced 2026-02-04 07:11:49 +00:00
8f0bc79e6f
Fix incorrect image URL formation when using separate name and tag parameters
where the tag contains a digest. Previously, tags like "8-bookworm@sha256:..."
would incorrectly use "@" as the delimiter between name and tag, resulting in
malformed URLs like "docker.io/valkey/valkey@8-bookworm@sha256:...".
The issue was in ImageRepository.delimiter logic which used substring matching
("sha256" in tag) instead of checking for pure digest format.
Changes:
- Fix delimiter selection in ImageRepository.__init__() to only use "@" for
pure digests starting with "sha256:", not any tag containing "sha256"
- Add comprehensive unit tests covering all delimiter scenarios
- Add integration tests with real digest validation and edge cases
- Ensure proper URL formation: name:tag@digest vs name@digest
Before: docker.io/valkey/valkey@8-bookworm@sha256:abc123 (broken)
After: docker.io/valkey/valkey:8-bookworm@sha256:abc123 (correct)
Fixes #947
Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
|
||
|---|---|---|
| .. | ||
| connection | ||
| connection_buildah | ||
| connection_podman | ||
| podman_container/tasks | ||
| podman_container_copy/tasks | ||
| podman_container_exec/tasks | ||
| podman_container_idempotency | ||
| podman_container_info/tasks | ||
| podman_containers/tasks | ||
| podman_export/tasks | ||
| podman_generate_systemd/tasks | ||
| podman_image | ||
| podman_image_info/tasks | ||
| podman_import/tasks | ||
| podman_load/tasks | ||
| podman_login/tasks | ||
| podman_login_info/tasks | ||
| podman_logout/tasks | ||
| podman_network/tasks | ||
| podman_network_info/tasks | ||
| podman_play/tasks | ||
| podman_pod/tasks | ||
| podman_pod_info/tasks | ||
| podman_prune/tasks | ||
| podman_runlabel | ||
| podman_save/tasks | ||
| podman_search/tasks | ||
| podman_secret/tasks | ||
| podman_secret_info/tasks | ||
| podman_system_info/tasks | ||
| podman_tag/tasks | ||
| podman_volume/tasks | ||
| podman_volume_info/tasks | ||
| __init__.py | ||