Sergey
f333fe7fca
Add podman system connection modules ( #971 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-25 09:35:27 +03:00
Sergey
ee52d9de78
Add podman image scp option ( #970 )
...
* Add podman image scp option
Fix #536
---------
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-19 23:30:35 +03:00
Sergey
9cffa671c8
Fix podman logout for newer Podman ( #969 )
...
Fix #935
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-18 23:15:41 +03:00
Sergey
6ee2f3891b
Add inventory plugins for buildah and podman ( #963 )
...
Add inventory plugins for buildah and podman, unit tests and functional CI tests.
---------
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-13 16:48:50 +03:00
Sergey
4d1917ac57
Add unittests for podman_image ( #961 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-06 00:05:07 +03:00
Sergey
8f0bc79e6f
Fix podman_image correct delimiter logic for version@digest tags ( #960 )
...
Fix incorrect image URL formation when using separate name and tag parameters
where the tag contains a digest. Previously, tags like "8-bookworm@sha256:..."
would incorrectly use "@" as the delimiter between name and tag, resulting in
malformed URLs like "docker.io/valkey/valkey@8-bookworm@sha256:...".
The issue was in ImageRepository.delimiter logic which used substring matching
("sha256" in tag) instead of checking for pure digest format.
Changes:
- Fix delimiter selection in ImageRepository.__init__() to only use "@" for
pure digests starting with "sha256:", not any tag containing "sha256"
- Add comprehensive unit tests covering all delimiter scenarios
- Add integration tests with real digest validation and edge cases
- Ensure proper URL formation: name:tag@digest vs name@digest
Before: docker.io/valkey/valkey@8-bookworm@sha256:abc123 (broken)
After: docker.io/valkey/valkey:8-bookworm@sha256:abc123 (correct)
Fixes #947
Generated with [Claude Code](https://claude.ai/code )
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-05 23:05:17 +03:00
Sergey
e37123e06f
Rewrite podman_image and add tests ( #957 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-04 16:28:35 +03:00
Sergey
91d991f95b
Add building Podman from source ( #955 )
...
* Add building Podman from source
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-08-03 13:30:27 +03:00
Sergey
43e9e4c5aa
Fix obsolete image in CI ( #949 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-07-14 20:31:36 +03:00
Sergey
f41939d8d8
Replace image in tests from quay.io ( #948 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-07-12 16:38:54 +03:00
Sergey
87be6de5c7
Add ignore file for Ansible 2.20 ( #946 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-07-01 16:25:35 +03:00
johnsonlien
aa20ede71e
Add podman system info module ( #922 )
...
Add podman system info module
Signed-off-by: johnsonlien <johnsonlien95@gmail.com>
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
Co-authored-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-06-22 13:13:11 +03:00
Sergey
f6bd81e820
Add another test for volumes ( #942 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-06-22 12:25:25 +03:00
lucas-benedito
6ff93e7559
podman_container_lib: Added checks for volume opts ( #941 )
...
* podman_container_lib: Added checks for volume opts
Changed the diffparam_volume function to include the volume mount opts.
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
* Add test for volume mount options
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
---------
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
2025-06-22 12:17:32 +03:00
Sergey
4c682e170c
Run black -l 120 on all Python files to unify the style ( #939 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-06-15 18:25:48 +03:00
Sergey
11cc00e6ca
Fix idempotency for systemd keyword ( #937 )
...
Fix #936
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-05-29 14:16:09 +03:00
André Lersveen
ac5da409fe
Fix idempotency for any podman secret driver ( #929 )
...
* Fix idempotency for any podman secret driver
All secret drivers are provided with the same interface in podman, so there is no need to hardcode the state as changed for all drivers other than 'file'.
Signed-off-by: lersveen <7195448+lersveen@users.noreply.github.com>
* ci: add tests for shell secret driver
Signed-off-by: lersveen <7195448+lersveen@users.noreply.github.com>
---------
Signed-off-by: lersveen <7195448+lersveen@users.noreply.github.com>
2025-05-13 15:06:45 +03:00
Sergey
2c040aa346
Set custom tmpfs idempotency ( #932 )
...
Fix #918
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-05-12 12:20:02 +03:00
Sergey
f1a9456147
Fix conditions in CI jobs ( #928 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-04-28 00:14:28 +03:00
Evgeni Golov
6946a0bcbd
correctly quote labels and environment variables for quadlets ( #920 )
...
Fixes : #807
Signed-off-by: Evgeni Golov <evgeni@golov.de>
2025-04-14 14:47:20 +03:00
Sergey
d901da6301
Fix CI for podman_image_info ( #912 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-03-09 16:14:55 +02:00
Sergey
7fa610a416
Convert DNS domain search to a list ( #881 )
...
Fix #880
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-12-13 20:34:17 +02:00
Sergey
a77ca6ab85
Fix list tags failure in podman_search ( #875 )
...
Fix #874
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-11-05 14:35:07 +02:00
Sergey
62348545b8
Add option to specify kube file content in module ( #863 )
...
Fix #463
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-10-23 18:35:25 +03:00
Guillaume HOUDMON
2deadf069a
Add quadlet file mode option to specify file permission ( #867 )
...
* Add quadlet file mode option
Signed-off-by: ghoudmon <guillaume@houdmon.com>
* Fix file mode only change test
Signed-off-by: ghoudmon <guillaume@houdmon.com>
---------
Signed-off-by: ghoudmon <guillaume@houdmon.com>
2024-10-22 15:20:26 +03:00
Martin Jackson
e46c7eb1a1
Add secret to login module ( #858 )
...
Signed-off-by: Martin Jackson <mhjacks@swbell.net>
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
2024-10-07 23:08:29 +03:00
Thomas Preindl
8daec72a04
Add missing parameters for podman container quadlet ( #847 )
...
* Revert "Add group_add parameter for podman quadlet (#827 )"
This reverts commit 4f24eced99 .
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Add 'group_add' to 'GroupAdd' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Add 'cgroups' to 'CgroupsMode' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Fix 'etc_hosts' to 'AddHost' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Fix 'network_aliases' to 'NetworkAlias' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Fix 'stop_signal' to 'StopSignal' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Add 'cpus' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Add 'platform' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
* Add 'log_opt' to 'LogOpt' parameter mapping for podman container quadlet
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
---------
Signed-off-by: Thomas Preindl <tompre@users.noreply.github.com>
2024-10-06 23:29:58 +03:00
Sergey
4f8ab01fbb
Fix podman image permissions issue and runlable test ( #853 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-09-26 09:50:54 +03:00
Sergey
c11b2af89d
CI: add ignore list for Ansible sanity for 2.19 ( #850 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-09-24 12:16:23 +03:00
SkrrtBacharach
58edc41196
Trigger a new image build when we detect that the Containerfile has changed. ( #811 )
...
* Trigger a new image build when we detect that the Containerfile has
changed.
Signed-off-by: gw <gw@bob.lol>
* Fix return type issues from PR feedback
Signed-off-by: gw <gw@bob.lol>
---------
Signed-off-by: gw <gw@bob.lol>
Co-authored-by: gw <gw@bob.lol>
2024-09-23 22:36:33 +03:00
Sergey
2adc93ffb1
CI: change k8s.gcr.io to registry.k8s.io in tests ( #842 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-09-09 11:25:50 +03:00
Benjamin MENANT
ac3a7a5fde
fix(podman_save): always changed when force ( #834 )
...
fixes #826
Signed-off-by: Benjamin Menant <dev@menant-benjamin.fr>
2024-09-02 18:52:14 +03:00
Sergey
ba88eda0fc
CI: Add images removal for tests ( #817 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-08-16 15:11:12 +03:00
Alessandro Rossi
92fe1464a0
fix for tls_verify being ignored ( #815 )
...
Signed-off-by: kubealex <al.rossi87@gmail.com>
2024-08-15 16:26:09 +03:00
Alessandro Rossi
eb46429493
Add podman_container_copy module ( #813 )
...
Signed-off-by: kubealex <al.rossi87@gmail.com>
2024-08-13 12:56:47 +03:00
Sergey
202a0fb6da
CI: fix Podman search of invalid image ( #812 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-08-07 14:52:57 +03:00
Sergey
3e303c7797
Fix podman CI test container images ( #804 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-07-14 23:24:19 +03:00
Sergey
d25cf57967
Idempotency improvements ( #795 )
...
* Fix integers in Quadlet generation
* Work around quotes in command for idempotency
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-07-07 22:55:26 +03:00
Sergey
24c842fdd6
Fix idempotency for empty values ( #790 )
...
Fix #788
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-20 09:53:16 +03:00
Sergey
c7a2aec93c
Fix CI job for podman_image in push to docker ( #785 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-13 15:06:44 +03:00
Sergey
e60d54f629
Add option for inline Containerfile in podman_image ( #781 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-09 14:37:33 +03:00
Derek Waters
38d95029e8
Add podman search ( #770 )
...
* Add podman_search module
Signed-off-by: Derek <derek@frisbeeworld.com>
2024-06-03 09:49:29 +03:00
Sergey
4cb8404b7b
Fix issue with pushing podman image to repo name and org ( #771 )
...
If destination doesn't have image, but only repo name and org,
complete with image name and tag.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-02 21:01:06 +03:00
Sergey
d75126d68a
Add path and env options for podman_secret ( #766 )
...
Fix #741
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-29 23:23:34 +03:00
Sergey
f9ab05b0ae
Add mount and unmount for volumes ( #764 )
...
Fix #603
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-29 18:28:44 +03:00
Sergey
4985d48415
Reapply "Fix transports issues in podman_image ( #619 )" ( #754 ) ( #755 )
...
This reverts commit 391e4c54ef .
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-29 18:27:07 +03:00
Sergey
0e24de1dd3
Add new functionality tests for podman_secret ( #765 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-29 10:41:30 +03:00
Sergey
863ac0e38a
Add docs, tests and more examples for podman_pod ( #763 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-29 10:24:01 +03:00
Sergey
9142efd82a
Add multiple subnets for networks ( #762 )
...
Improve idempotency.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-28 18:36:52 +03:00
Sergey
2887be7289
Add route, dns and ipam_driver to podman_network ( #761 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-27 21:59:14 +03:00