Sergey
f2e813671a
Run black -l 120 on all files, again ( #943 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-06-26 13:24:44 +03:00
lucas-benedito
6ff93e7559
podman_container_lib: Added checks for volume opts ( #941 )
...
* podman_container_lib: Added checks for volume opts
Changed the diffparam_volume function to include the volume mount opts.
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
* Add test for volume mount options
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
---------
Signed-off-by: Lucas Benedito <lbenedit@redhat.com>
2025-06-22 12:17:32 +03:00
Sergey
4c682e170c
Run black -l 120 on all Python files to unify the style ( #939 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-06-15 18:25:48 +03:00
Sergey
11cc00e6ca
Fix idempotency for systemd keyword ( #937 )
...
Fix #936
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-05-29 14:16:09 +03:00
Sergey
2c040aa346
Set custom tmpfs idempotency ( #932 )
...
Fix #918
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-05-12 12:20:02 +03:00
Sergey
5ea945dffe
Handle image arguments in podman_container ( #931 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-05-11 18:38:49 +03:00
Sergey
47767dab21
Remove docker protocol when inspecting image ( #901 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-02-17 15:17:47 +02:00
Sergey
64e4247347
Don't pull image when state is absent or pull=never ( #889 )
...
fix #888
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2025-01-08 15:38:03 +02:00
Sergey
7fa610a416
Convert DNS domain search to a list ( #881 )
...
Fix #880
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-12-13 20:34:17 +02:00
Sergey
4d3009fda9
Don't check image availability in Quadlet ( #872 )
...
Fix #871
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-10-27 20:35:45 +02:00
Guillaume HOUDMON
2deadf069a
Add quadlet file mode option to specify file permission ( #867 )
...
* Add quadlet file mode option
Signed-off-by: ghoudmon <guillaume@houdmon.com>
* Fix file mode only change test
Signed-off-by: ghoudmon <guillaume@houdmon.com>
---------
Signed-off-by: ghoudmon <guillaume@houdmon.com>
2024-10-22 15:20:26 +03:00
Sergey
46d4378426
Fix command idempotency with quotes ( #839 )
...
Fix #838
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-09-05 19:31:28 +03:00
Sergey
83d0eefcb5
Disable idempotency for pod_id_file ( #829 )
...
Fix #828
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-09-02 19:54:39 +03:00
Alessandro Rossi
92fe1464a0
fix for tls_verify being ignored ( #815 )
...
Signed-off-by: kubealex <al.rossi87@gmail.com>
2024-08-15 16:26:09 +03:00
Holger Hees
93c1532b04
Fix health-startup-cmd ( #809 )
...
"--health-startup-command" is a wrong parameter.
the correct syntax is
"--health-startup-cmd"
2024-08-15 13:56:21 +03:00
Sergey
4e65a7bc94
Fix quadlet parameters for restart policy ( #798 )
...
Fix #797
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-07-11 11:13:56 +03:00
Sergey
d25cf57967
Idempotency improvements ( #795 )
...
* Fix integers in Quadlet generation
* Work around quotes in command for idempotency
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-07-07 22:55:26 +03:00
Sergey
8a8f9023e6
Fix idempotency for systemd generations ( #776 )
...
Fix #775
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-07 00:08:02 +03:00
Sergey
47fc4cc119
Redesign idempotency for Podman Pod module ( #759 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-27 17:49:32 +03:00
Sergey
e29e2cfb19
Improve idempotency for networking in podman_container ( #756 )
...
Related: #555
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-23 13:33:01 +03:00
Sergey
e1e4e7516a
Add idempotency for mounts and volumes ( #753 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-22 22:08:57 +03:00
Sergey
2f5da14c30
Add new options for podman_container ( #750 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-22 14:30:28 +03:00
Sergey
1476ebe685
Add quadlet support for Podman modules ( #722 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-22 01:13:04 +03:00
Sagi Shnaidman
cb74414e50
Fix pod for Podman v5
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-08 01:11:46 +03:00
Sagi Shnaidman
453be5c5fd
Add check and fixed for v5 network diff
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-08 01:11:46 +03:00
Sagi Shnaidman
ace1f5896a
Add pasta as default network mode after v5
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-08 01:11:46 +03:00
Sergey
7dce3c9c8e
Fix pasta networking idempotency for v5 ( #728 )
...
Fix #721
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-05 13:49:50 +03:00
ant-bl
2e661d1700
Update env_file to accept a list of files instead of a single file ( #702 )
...
* Update env_file to accept a list of files instead of a single file
Signed-off-by: antoine <antoine.blin@gandi.net>
* Update doc: add alias env_files
Signed-off-by: antoine <antoine.blin@gandi.net>
* Update plugins/module_utils/podman/podman_container_lib.py
Use real arg name and not alias
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
---------
Signed-off-by: antoine <antoine.blin@gandi.net>
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
2024-01-25 14:04:40 +02:00
Sergey
35cac483c9
Add new arguments to podman status commands ( #703 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-01-23 11:28:55 +02:00
Sergey
1fe9642576
Add option to parse CreateCommand easily for diff calc ( #698 )
...
We have a few calculations of given options and arguments from
CreateCommand, so let's do it in a more convinient way.
Define a function _createcommand which receives an argument
and returns all values for it in a command line of Podman.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-01-11 15:30:24 +02:00
Sergey
2d006399b0
Fix idempotency when using 0.0.0.0 in ports ( #679 )
...
Fix #678
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-11-30 15:12:17 +02:00
Roberto Alfieri
b693cb6b89
Recreate stopped containers if recreate flag is enabled ( #669 )
...
If `recreate` flag is enabled we should be able to (force) recreate stopped
containers even if they're configuration isn't changed.
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
2023-11-28 10:14:24 +02:00
Roberto Alfieri
6c87654f7f
Improve security_opt comparison between existing container ( #673 )
...
Since SElinux labels are basically annotations, they are merged in a single comma separated string in the list by podman, so we need to split them in a sorted list if we want to compare it to the list that we provide to the module.
Also, a proper test of this example has been added.
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
2023-11-28 10:13:17 +02:00
Denis Medeiros
3c0d2cc58c
Add support for health-on-failure action ( #658 )
...
Signed-off-by: Denis Medeiros <denis.medeiros@bbd.ca>
2023-11-01 11:31:55 +02:00
Sergey
11f9eded6a
Fix idempoency issue with PID of container ( #622 )
...
Fix #573
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-12 14:25:09 +03:00
Sergey
faee18ecdc
Fix healthcheck issue where defined in image ( #618 )
...
Fix #598
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-12 11:32:39 +03:00
Sergey
aeec6b92d6
Revert "Use replace option to recreate a container ( #613 )" ( #616 )
...
This reverts commit cb832c9a84
2023-08-07 11:08:18 +03:00
Sergey
cb832c9a84
Use replace option to recreate a container ( #613 )
...
In recreating container use `--replace` option.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-06 21:26:15 +03:00
Sergey
7a307453a5
Add diff and change detection to systemd generation ( #608 )
...
Fix #339
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-03 16:26:18 +03:00
Holger Müller
cc34c2b780
added cpu_quota parameter to podman_container ( #612 )
...
* added cpu_qouta parameter to podman_container
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* add missing key to parameter dict
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
---------
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
Co-authored-by: Holger Mueller <holger.mueller@inovex.de>
2023-08-03 15:57:10 +03:00
Holger Müller
2914785411
Fixed idempotency with cpus parameter ( #581 )
...
* Added cpu_quota parameter and fixed #559
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* force float for cpu parameter in diff
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* fixed typo
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* revert linebreak caused by linting with too short lines
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* removed quota parameter from patch
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* readded already existing quota key to defaults
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
---------
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
Co-authored-by: Holger Mueller <holger.mueller@inovex.de>
2023-08-03 15:29:06 +03:00
Sergey
4e2f42eea6
Fix idempotency for devices ( #611 )
...
Fix #610
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-02 18:21:43 +03:00
sedrubal
0ae6baac3d
Fix idempotency for RestartPolicy when MaximumRetryCount > 0 ( #607 )
...
Before this change, this task:
```ansible
- containers.podman.podman_container:
# ...
restart_policy: on-failure:3
# ...
```
always caused this diff:
```diff
--- before
+++ after
@@ -1 +1 @@
-restart_policy - on-failure
+restart_policy - on-failure:3
```
Signed-off-by: Sebastian Endres <sebastian.endres@dlr.de>
Co-authored-by: Sebastian Endres <sebastian.endres@dlr.de>
2023-07-30 21:59:13 +03:00
Sergey
9d168430a4
Fix idempotency lowercase for devices ( #549 )
...
Fix : #537
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-13 13:24:11 +02:00
Sergey
8f5842dea6
Add idempotency for restart-policy for containers ( #548 )
...
Fix : #440
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-12 13:00:00 +02:00
Sergey
132baa18e4
Add hooks-dir parameter for containers ( #547 )
...
Fix #539
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-12 01:47:46 +02:00
linxside
a762dc63d0
Fix undesirable splitting of IPv6 host addresses ( #533 )
...
* fix: over splitting for ipv6 addresses
Signed-off-by: linxside <git@linux-inside.de>
* test: add test cases for ipv6 oversplitting
Signed-off-by: linxside <git@linux-inside.de>
Signed-off-by: linxside <git@linux-inside.de>
2022-12-13 03:50:40 +02:00
Sergey
5198b726fb
Delete systemd files when container/pod is deleted ( #508 )
...
Fix #489
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-11-10 17:13:45 +02:00
Sergey
bf67c7e078
Improve idempotency for devices mount of rootless podman ( #487 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-28 12:39:15 +03:00
Sergey
93b5acbf6e
Support passing multiple networks with params ( #472 )
...
Fix #467
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-03 10:40:48 +03:00
