1
0
Fork 0
mirror of https://github.com/containers/ansible-podman-collections.git synced 2026-04-13 04:45:00 +00:00
Commit graph

178 commits

Author SHA1 Message Date
Sergey
cecb29222e
Add --sdnotify option for container (#465)
Fix #464

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-08-28 16:42:31 +03:00
Nikita Tokarchuk
9068baeb99
podman_container should ensure image by using os path if rootfs is used (#458)
* Check image with os path if rootfs is used

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Take into account rootfs usage while evaluating a diff

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Always compare rootfs image diffparam as strict

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Reverse image labels getter to ignore the value if None

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Add tests to check podman rootfs containers

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>
2022-08-12 06:26:16 +03:00
Albrecht
08dd7b0ceb
add required argument to example (#461)
Signed-off-by: weichweich <archbelt@posteo.de>
2022-08-08 22:28:15 +03:00
Sergey
e6544bdd0a
Fix PEP8 issue in podman_image (#459)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-07-31 22:47:17 +03:00
Adrian Freund
99c2851341
Fix rerunning playbooks with generate_systemd --new (#453)
* Fix restarting containers if --rm is enabled
* Automatically enable rm if generate_systemd.new is set
* Don't assume that the 'new' key in generate_systemd exists

Signed-off-by: Adrian Freund <adrian@freund.io>
2022-07-22 17:41:21 +03:00
Sergey
db27c68ef9
Fix pod tests in CI (#445)
Remove 'net' from pod idempotency if it's not in inspection.
Probably a bug on Ubuntu.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-07-04 15:46:35 +03:00
Sagi Shnaidman
75198ae574 Fix pod network idempotency
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-07-01 10:23:12 +03:00
Sagi Shnaidman
6c862b29e7 Fix pods list retrieve
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-07-01 10:23:12 +03:00
Sagi Shnaidman
542986cd8a Pass errors as a string instead of list 2022-07-01 10:23:12 +03:00
Rabi Mishra
6dc481ae2c
Change IpcMode default to shareable (#444)
podman 4.1.x has changed the ipc namespace mode default to
shareable[1] that results in containers being restarted.

[1] 3987c529f4

Resolves: rhbz#2101495
Signed-off-by: Rabi Mishra <ramishra@redhat.com>
2022-06-29 03:10:45 +03:00
Sergey
2577f5b0f5
Remove distutils as deprecated (#437)
Fix #422
The distutils package is deprecated and slated for removal in Python 3.12

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-06-12 22:54:03 +03:00
Cleber Rosa
1003e966ee
Add missing docstring for method that executes the podman commands (#436)
For completeness sake (and because I looked for it and did not find
it), this adds a docstring line for the "use_container_id" parameter.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
2022-06-11 14:35:29 +03:00
Sergey
25b9516488
Allow specify podman_network options MTU and VLAN separately (#435)
Before that it didn't work when only one option set.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-06-08 19:37:06 +03:00
nishipy
acedce8b4b
Update podman_image to remove image with image id (#434)
* Update to remove image with image id.

Signed-off-by: nishipy <goodisonev4@gmail.com>
2022-06-08 18:51:25 +03:00
Clemens Lange
b33a657f00
Fix idempotency for podman_login (#430)
Signed-off-by: Clemens Lange <clemens.lange@cern.ch>
2022-06-06 12:18:08 +03:00
Benjamin Schubert
15dae0d9ad
podman_container.py: Fix typo in the documentation (#424)
I believe "prefix" is what was meant here

Signed-off-by: Benjamin Schubert <contact@benschubert.me>
2022-05-22 15:08:16 +03:00
Oscar
20a982b564
Fix play_kube not working when yaml not installed on target (#415) (#419)
Signed-off-by: tcmal <oscar.shrimpton.personal@gmail.com>
2022-05-01 11:48:43 +03:00
Sergey
98c516292f
Fix internal networks idempotency (#421)
Remove logic with internal and dns, since Podman supports it in
recent versions.
Fix #350
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-04-28 00:56:22 +03:00
Sergey
848034096c
Disable memory idempotency (#420)
Because of complexity in Podman logic and calculations of b/m/g
etc let's disable this idempotency for now.
Fix #418

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-04-28 00:26:28 +03:00
Sergey
e5d6136694
Change network attribute from str to list in pods #414 #416 (#417)
* Change network attribute from str to list in pods

Signed-off-by: André Cirne <dumahk21@gmail.com>

* Fix tests

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>

Co-authored-by: André Cirne <dumahk21@gmail.com>
2022-04-25 02:15:29 +03:00
MasterWaldo
b51dc5c814
Loop over image names when multiple images present in archive (#413)
Signed-off-by: Cory Prelerson <cprelerson42@gmail.com>
2022-04-24 22:38:53 +03:00
Sergey
fefc7e461f
Remove idempotency for log level (#404)
Since Podman changes its defaults very often and it's impossible
to track and identify every time what is current log level, let's
remove idempotency for this parameter for now.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-29 14:15:16 +03:00
Henry78
4afd6bbd18
Podman Pod: Update examples to use quotes when publishing ports to avoid them being intrepreted as scalars. #394 (#401)
Signed-off-by: Henry <henry78@gmx.at>
2022-03-24 11:46:54 +02:00
Sergey
aa4c3223d2
Fix podman collection for Podman version 4 (#398)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-17 21:56:19 +02:00
Axel Dahlberg
4a7d64bb43
fix(network) fix issue when missing plugins entry (#392)
Signed-off-by: Axel Dahlberg <git@valleymnt.com>
2022-03-14 13:41:28 +02:00
Rubik's Dot
d024e91216
fix check for read-only change of root image (#393)
The --read-only option is not checked for changes between runs of
ansible thus the container is not recreated if the user changes
the root image between read-write to read-only.

Default for the read_only variable set to False in line with
documentation and so that later checks are simplified.

This is a fix for bug #383.

Signed-off-by: Andrew <rubiksdot@grue.cc>

Co-authored-by: Andrew <rubiksdot@grue.cc>
2022-03-14 12:54:12 +02:00
Sergey
81f20befb2
Fix error with exitcommand for Podman v4 (#390)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-11 12:13:36 +02:00
Sergey
85a36e3b1f
Fix new requirements for plugins documentation (#385)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-08 13:58:38 +02:00
Sergey
081ac5f851
Fix MAC address detection in created container (#377)
Fix #373

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 20:17:57 +02:00
Sergey
527ccacf01
Add --requires option (#378)
Fix #374
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 18:53:37 +02:00
Sergey
23fde625f6
Strip slashes from volumes (#379)
Fix #372

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 18:29:51 +02:00
Sergey
547abfea53
Add slirp4netns idempotency for pods (#369)
Fix #367
2022-01-16 23:44:08 +02:00
Sergey
4f3a84f4e5
Add new options for pod module (#361) 2022-01-13 15:10:05 +02:00
Aliaksandr Mianzhynski
d185616a72
Update secrets description and add test with secret opts (#363)
* Update secrets description and add test with secret opts

* Make pep happy
2022-01-06 18:08:09 +02:00
Radovan Dražný
42dc5be784
Handle tlsverify correctly in podman_login (#365) 2022-01-06 17:00:10 +02:00
Timo Tomasini
9860b78ce5
Fix podman_pod_lib behavior for ports published to multiple IPs (#359)
* Fix podman_pod_lib behavior for ports published to multiple IPs

* Fix IPv6 behavior for pods and add tests

* Fix bind: cannot assign requested address issue with test container
2022-01-03 08:24:51 +02:00
Joerg Kastning
6ba6c01229
Add a second example to podman_pod_module.html (#346)
Added a second example
2021-11-29 00:13:31 +02:00
Sergey
d5e52d813f
Don't include shared 'net' if network is host in pods (#348) 2021-11-29 00:04:53 +02:00
Sergey
05515e8307
Add CI jobs and docs for podman_tag (#347) 2021-11-28 22:31:18 +02:00
Christian Bourque
f2882ecb19
Add podman_tag module #328 (#343)
Fixes #328
Co-authored-by: Christian Bourque <christian.bourque@expretio.com>
2021-11-28 18:02:24 +02:00
Aliaksandr Mianzhynski
3e7f7a00a0
Add secrets driver and driver opts support (#344) 2021-11-26 12:22:36 +02:00
Sergey
5db058ac67
Remove default value of log-driver (#340)
The default value of log-driver is not defined now and can change
depending on the platform.
2021-11-25 19:06:02 +02:00
Oliver Walsh
f3e95d0d3f
Hardcode RT signal numbers (#338)
Looking up SIGRTMIN/SIGRTMAX isn't portable.
Hardcode the Linux signal number instead.

Fixes issue #337.
2021-11-20 03:06:07 +02:00
zephyros
e6d2e86e35
Add documentations for generate_systemd (#336) 2021-11-19 16:04:06 +02:00
Luca Beltrame
cef7bdbea0
Support --new in generate_systemd (#334)
* Support --new in generate_systemd

Fixes #318.

* Add docs
2021-11-18 14:35:42 +02:00
Cédric Jeanneret
a8e81193f4
Allow to actually pass a list of string for "mounts" (#332)
Like "volume", "mount" can be passed multiple times to the container
creation/run, therefore we want to support a list of string, and a
"mounts" alias.
2021-11-09 13:40:40 +02:00
Mike
aa6d538be9
Don't add newlines to secrets (#331)
* prevent run_command from creating new lines
* removes new line from test
2021-11-01 22:22:57 +02:00
Oliver Walsh
a0377fbd24
Fix signal diff for truncated and RT signal names (#326)
* Fix signal diff for truncated and RT signal names

This refactors the signal mapping logic to closely resemble the logic in
podman.

Podman tolerates images with truncated STOPSIGNAL names e.g RTMIN+3
is used in the freeipa-container Dockerfiles.

Also avoids hardcoding real-time signals as they vary per
platform or glibc implementation (see man 7 signal).

* Cleanup lint

* More lint cleanup
2021-10-19 17:18:22 +03:00
Sean Sullivan
e90eb325ae
Update error message when pull set to false (#327) 2021-10-19 02:01:52 +03:00
Sergey
4982579c79
Add skip option for podman secret (#324) 2021-10-12 13:56:04 +03:00