Richard Megginson
c3c5877279
params gpus should be exit_policy ( #784 )
...
The code should be setting `--exit-policy` to the value of `params['exit_policy']`
instead of `params['gpus']`
Signed-off-by: Rich Megginson <rmeggins@redhat.com>
2024-06-13 14:35:10 +03:00
Sergey
9c40a88a71
Fix idempotency for pods in case of systemd generation ( #777 )
...
Fix #774
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-07 00:15:57 +03:00
Sergey
8a8f9023e6
Fix idempotency for systemd generations ( #776 )
...
Fix #775
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-06-07 00:08:02 +03:00
Sergey
47fc4cc119
Redesign idempotency for Podman Pod module ( #759 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-27 17:49:32 +03:00
Sergey
e29e2cfb19
Improve idempotency for networking in podman_container ( #756 )
...
Related: #555
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-23 13:33:01 +03:00
Sergey
e1e4e7516a
Add idempotency for mounts and volumes ( #753 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-22 22:08:57 +03:00
Sergey
2f5da14c30
Add new options for podman_container ( #750 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-22 14:30:28 +03:00
Marko Weltzer
9f34e8f78a
fix( #747 ): set correct HealthCmd ( #748 )
...
Signed-off-by: Marko Weltzer <marwel_github@bugga.de>
2024-05-19 22:27:52 +03:00
Sergey
b987120fa0
Add new options to pod module ( #745 )
...
Fix #742
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-16 14:50:47 +03:00
Sergey
4c987a1c22
Fix idempotency for pod with 0.0.0.0 ( #744 )
...
Fix #743
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-05-13 17:21:03 +03:00
Sergey
1476ebe685
Add quadlet support for Podman modules ( #722 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-22 01:13:04 +03:00
Sagi Shnaidman
cb74414e50
Fix pod for Podman v5
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-08 01:11:46 +03:00
Sagi Shnaidman
453be5c5fd
Add check and fixed for v5 network diff
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-08 01:11:46 +03:00
Sagi Shnaidman
ace1f5896a
Add pasta as default network mode after v5
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-08 01:11:46 +03:00
Sergey
7dce3c9c8e
Fix pasta networking idempotency for v5 ( #728 )
...
Fix #721
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-04-05 13:49:50 +03:00
Sagi Shnaidman
42f10519ec
Fix podman pod v5 broken info issue
...
Fix breakig change introduced in Podman v5:
https://github.com/containers/podman/pull/21514
Related-to: #712
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-02-18 00:01:09 +02:00
Adam Williamson
7d7445d29b
podman pod info: handle return being list in Podman 5 ( #713 )
...
Fixes #712
Podman 5 changed the output of `podman pod info` (when run on a
single pod) from being a dict to being a list of dicts:
https://github.com/containers/podman/pull/21514
this should handle both ways. Unfortunately not sure how to add
a test for this as I can't see a unit test that mocks the output
of the command, only the integration test that gets real live
output, and I'm not sure how to get that test run with Podman 5.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-02-17 21:47:19 +02:00
ant-bl
2e661d1700
Update env_file to accept a list of files instead of a single file ( #702 )
...
* Update env_file to accept a list of files instead of a single file
Signed-off-by: antoine <antoine.blin@gandi.net>
* Update doc: add alias env_files
Signed-off-by: antoine <antoine.blin@gandi.net>
* Update plugins/module_utils/podman/podman_container_lib.py
Use real arg name and not alias
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
---------
Signed-off-by: antoine <antoine.blin@gandi.net>
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
2024-01-25 14:04:40 +02:00
Sergey
35cac483c9
Add new arguments to podman status commands ( #703 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-01-23 11:28:55 +02:00
Sergey
1fe9642576
Add option to parse CreateCommand easily for diff calc ( #698 )
...
We have a few calculations of given options and arguments from
CreateCommand, so let's do it in a more convinient way.
Define a function _createcommand which receives an argument
and returns all values for it in a command line of Podman.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2024-01-11 15:30:24 +02:00
Sergey
f9cbca5582
Add idempotency for podman_secret ( #693 )
...
* Add idempotency for podman_secret
Fix #692
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
* Add lables support for podman_secret
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
---------
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-12-23 18:52:25 +02:00
Alessandro Fulgini
4d233a4146
Alias generate systemd options stop_timeout and time ( #685 )
...
* Alias generate systemd options `stop_timeout` and `time`
Closes #683
Option `time` was used before Podman v4, then it was renamed
`stop_timeout`.
Accept both names (the newer takes prirority) and set the correct
CLI argument name based on the detected Podman version.
Signed-off-by: Alessandro Fulgini <fuljo97@gmail.com>
* Fix typo in parameter name `--stop-timeout`
Signed-off-by: Alessandro Fulgini <fuljo97@gmail.com>
* Don't delete temporary variables at the end of block
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
---------
Signed-off-by: Alessandro Fulgini <fuljo97@gmail.com>
Co-authored-by: Sergey <6213510+sshnaidm@users.noreply.github.com>
2023-12-07 11:24:28 +02:00
Sergey
edcb13dd8a
Fail if systemd generation failed and it's explicitly set ( #682 )
...
Fix #675
If we explicitly set to generate systemd with parameters, fail
the module if the generation failed.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-11-30 16:04:51 +02:00
Sergey
2d006399b0
Fix idempotency when using 0.0.0.0 in ports ( #679 )
...
Fix #678
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-11-30 15:12:17 +02:00
Roberto Alfieri
b693cb6b89
Recreate stopped containers if recreate flag is enabled ( #669 )
...
If `recreate` flag is enabled we should be able to (force) recreate stopped
containers even if they're configuration isn't changed.
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
2023-11-28 10:14:24 +02:00
Roberto Alfieri
6c87654f7f
Improve security_opt comparison between existing container ( #673 )
...
Since SElinux labels are basically annotations, they are merged in a single comma separated string in the list by podman, so we need to split them in a sorted list if we want to compare it to the list that we provide to the module.
Also, a proper test of this example has been added.
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
2023-11-28 10:13:17 +02:00
Denis Medeiros
3c0d2cc58c
Add support for health-on-failure action ( #658 )
...
Signed-off-by: Denis Medeiros <denis.medeiros@bbd.ca>
2023-11-01 11:31:55 +02:00
nishipy
2a8aaf4522
Add options for resource limits to podman_pod ( #635 )
...
* Add resource limiting paramters for podman_pod
Signed-off-by: nishipy <goodisonev4@gmail.com>
* Fix doc-elements-mismatch
Signed-off-by: nishipy <goodisonev4@gmail.com>
* Update tests for podman_pod
Signed-off-by: nishipy <goodisonev4@gmail.com>
---------
Signed-off-by: nishipy <goodisonev4@gmail.com>
2023-09-08 13:36:31 +03:00
Sergey
e025e928b2
Fix common file for Python 2.7 ( #643 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-09-06 13:28:52 +03:00
Sergey
e160458eb6
Fix idempotency when running inside Podman container ( #637 )
...
Fix #636
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-29 12:55:03 +03:00
Sergey
11f9eded6a
Fix idempoency issue with PID of container ( #622 )
...
Fix #573
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-12 14:25:09 +03:00
Sergey
faee18ecdc
Fix healthcheck issue where defined in image ( #618 )
...
Fix #598
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-12 11:32:39 +03:00
Sergey
aeec6b92d6
Revert "Use replace option to recreate a container ( #613 )" ( #616 )
...
This reverts commit cb832c9a84
2023-08-07 11:08:18 +03:00
Sergey
cb832c9a84
Use replace option to recreate a container ( #613 )
...
In recreating container use `--replace` option.
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-06 21:26:15 +03:00
Sergey
ff12ccddaf
Add restart-sec and other options to systemd generation. ( #615 )
...
Add restart_sec, start_timeout_sec and stop_timeout_sec
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-06 21:15:36 +03:00
Sergey
7a307453a5
Add diff and change detection to systemd generation ( #608 )
...
Fix #339
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-03 16:26:18 +03:00
Holger Müller
cc34c2b780
added cpu_quota parameter to podman_container ( #612 )
...
* added cpu_qouta parameter to podman_container
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* add missing key to parameter dict
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
---------
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
Co-authored-by: Holger Mueller <holger.mueller@inovex.de>
2023-08-03 15:57:10 +03:00
Holger Müller
2914785411
Fixed idempotency with cpus parameter ( #581 )
...
* Added cpu_quota parameter and fixed #559
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* force float for cpu parameter in diff
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* fixed typo
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* revert linebreak caused by linting with too short lines
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* removed quota parameter from patch
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
* readded already existing quota key to defaults
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
---------
Signed-off-by: Holger Mueller <holger.mueller@inovex.de>
Co-authored-by: Holger Mueller <holger.mueller@inovex.de>
2023-08-03 15:29:06 +03:00
Sergey
4e2f42eea6
Fix idempotency for devices ( #611 )
...
Fix #610
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-08-02 18:21:43 +03:00
Benjamin Schubert
9aedda4443
Fix idempotency checks when using userns ( #599 )
...
Previously, this would only mark the userns as expected when `uidmap`
or `gidmap` is passed. However, in the case `userns` is passed, this
is also expected to be set.
Signed-off-by: Benjamin Schubert <contact@benschubert.me>
2023-07-31 20:55:03 +03:00
sedrubal
0ae6baac3d
Fix idempotency for RestartPolicy when MaximumRetryCount > 0 ( #607 )
...
Before this change, this task:
```ansible
- containers.podman.podman_container:
# ...
restart_policy: on-failure:3
# ...
```
always caused this diff:
```diff
--- before
+++ after
@@ -1 +1 @@
-restart_policy - on-failure
+restart_policy - on-failure:3
```
Signed-off-by: Sebastian Endres <sebastian.endres@dlr.de>
Co-authored-by: Sebastian Endres <sebastian.endres@dlr.de>
2023-07-30 21:59:13 +03:00
Sergey
45e1de2bfe
podman-pod: Fix idempotency for pods in 4.4.x versions ( #593 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-05-30 19:52:51 +03:00
Benjamin Schubert
7c06ddec3b
pod: Support passing multiple networks with params ( #553 )
...
Similar to #472 , but for pods. there is also support there
Signed-off-by: Benjamin Schubert <contact@benschubert.me>
2023-02-24 12:15:43 +02:00
Sergey
1bfa6396a5
Fix pylint issues for CI ansible-test ( #550 )
...
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-14 16:22:36 +02:00
Sergey
9d168430a4
Fix idempotency lowercase for devices ( #549 )
...
Fix : #537
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-13 13:24:11 +02:00
Sergey
8f5842dea6
Add idempotency for restart-policy for containers ( #548 )
...
Fix : #440
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-12 13:00:00 +02:00
Sergey
132baa18e4
Add hooks-dir parameter for containers ( #547 )
...
Fix #539
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-12 01:47:46 +02:00
Sergey
c4bc7ccada
Fix idempotency for pods with uidmap and gidmap ( #546 )
...
Fix #543
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2023-02-12 01:42:20 +02:00
linxside
a762dc63d0
Fix undesirable splitting of IPv6 host addresses ( #533 )
...
* fix: over splitting for ipv6 addresses
Signed-off-by: linxside <git@linux-inside.de>
* test: add test cases for ipv6 oversplitting
Signed-off-by: linxside <git@linux-inside.de>
Signed-off-by: linxside <git@linux-inside.de>
2022-12-13 03:50:40 +02:00
Sergey
a90c040239
Fix expanduser in path for systemd generation ( #510 )
...
Use expanduser for path calculation.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2133207
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-11-11 11:00:47 +02:00
