1
0
Fork 0
mirror of https://github.com/containers/ansible-podman-collections.git synced 2026-04-28 11:58:48 +00:00
Commit graph

59 commits

Author SHA1 Message Date
Sergey
5198b726fb
Delete systemd files when container/pod is deleted (#508)
Fix #489

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-11-10 17:13:45 +02:00
Sergey
bf67c7e078
Improve idempotency for devices mount of rootless podman (#487)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-28 12:39:15 +03:00
Sergey
93b5acbf6e
Support passing multiple networks with params (#472)
Fix #467
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-03 10:40:48 +03:00
dada513
b72a026328
generate_systemd: implement --wants, --after and --requires (GH-431) (#432)
* generate_systemd: implement --wants, --after and --requires (GH-431)

Signed-off-by: dada513 <dada513@protonmail.com>
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
Co-authored-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-01 20:28:07 +03:00
Sergey
cecb29222e
Add --sdnotify option for container (#465)
Fix #464

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-08-28 16:42:31 +03:00
Nikita Tokarchuk
9068baeb99
podman_container should ensure image by using os path if rootfs is used (#458)
* Check image with os path if rootfs is used

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Take into account rootfs usage while evaluating a diff

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Always compare rootfs image diffparam as strict

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Reverse image labels getter to ignore the value if None

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Add tests to check podman rootfs containers

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>
2022-08-12 06:26:16 +03:00
Adrian Freund
99c2851341
Fix rerunning playbooks with generate_systemd --new (#453)
* Fix restarting containers if --rm is enabled
* Automatically enable rm if generate_systemd.new is set
* Don't assume that the 'new' key in generate_systemd exists

Signed-off-by: Adrian Freund <adrian@freund.io>
2022-07-22 17:41:21 +03:00
Rabi Mishra
6dc481ae2c
Change IpcMode default to shareable (#444)
podman 4.1.x has changed the ipc namespace mode default to
shareable[1] that results in containers being restarted.

[1] 3987c529f4

Resolves: rhbz#2101495
Signed-off-by: Rabi Mishra <ramishra@redhat.com>
2022-06-29 03:10:45 +03:00
Sergey
2577f5b0f5
Remove distutils as deprecated (#437)
Fix #422
The distutils package is deprecated and slated for removal in Python 3.12

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-06-12 22:54:03 +03:00
Sergey
848034096c
Disable memory idempotency (#420)
Because of complexity in Podman logic and calculations of b/m/g
etc let's disable this idempotency for now.
Fix #418

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-04-28 00:26:28 +03:00
Sergey
fefc7e461f
Remove idempotency for log level (#404)
Since Podman changes its defaults very often and it's impossible
to track and identify every time what is current log level, let's
remove idempotency for this parameter for now.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-29 14:15:16 +03:00
Sergey
aa4c3223d2
Fix podman collection for Podman version 4 (#398)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-17 21:56:19 +02:00
Rubik's Dot
d024e91216
fix check for read-only change of root image (#393)
The --read-only option is not checked for changes between runs of
ansible thus the container is not recreated if the user changes
the root image between read-write to read-only.

Default for the read_only variable set to False in line with
documentation and so that later checks are simplified.

This is a fix for bug #383.

Signed-off-by: Andrew <rubiksdot@grue.cc>

Co-authored-by: Andrew <rubiksdot@grue.cc>
2022-03-14 12:54:12 +02:00
Sergey
81f20befb2
Fix error with exitcommand for Podman v4 (#390)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-11 12:13:36 +02:00
Sergey
081ac5f851
Fix MAC address detection in created container (#377)
Fix #373

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 20:17:57 +02:00
Sergey
527ccacf01
Add --requires option (#378)
Fix #374
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 18:53:37 +02:00
Sergey
23fde625f6
Strip slashes from volumes (#379)
Fix #372

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 18:29:51 +02:00
Sergey
5db058ac67
Remove default value of log-driver (#340)
The default value of log-driver is not defined now and can change
depending on the platform.
2021-11-25 19:06:02 +02:00
Cédric Jeanneret
a8e81193f4
Allow to actually pass a list of string for "mounts" (#332)
Like "volume", "mount" can be passed multiple times to the container
creation/run, therefore we want to support a list of string, and a
"mounts" alias.
2021-11-09 13:40:40 +02:00
Oliver Walsh
a0377fbd24
Fix signal diff for truncated and RT signal names (#326)
* Fix signal diff for truncated and RT signal names

This refactors the signal mapping logic to closely resemble the logic in
podman.

Podman tolerates images with truncated STOPSIGNAL names e.g RTMIN+3
is used in the freeipa-container Dockerfiles.

Also avoids hardcoding real-time signals as they vary per
platform or glibc implementation (see man 7 signal).

* Cleanup lint

* More lint cleanup
2021-10-19 17:18:22 +03:00
Sergey
717963d66d
Fix issue with podman and exposed ports (#323) 2021-10-12 02:18:08 +03:00
Jad Kik
15cd7623af
Add support for network-alias flag (#314)
* Add support for network-alias flag
* Ignore idempotency assert in tests

Co-authored-by: Sagi Shnaidman <sshnaidm@redhat.com>
2021-10-03 22:18:31 +03:00
Sergey
5d37e1ee22
Add systemd generation for pods (#299) 2021-09-15 02:44:06 +03:00
Sergey
24329ce5d3
Generate systemd service files for containers (#298) 2021-09-13 17:13:15 +03:00
Sergey
afe55dd277
Fix idempotency when containers have a common network (#279)
Fix #252
2021-08-16 14:28:57 +03:00
Aliaksandr Mianzhynski
e9ace7b4bf
Add initial secrets support (#284)
* Add initial secrets support
2021-08-10 15:35:48 +03:00
Sergey
ed681ef10e
Fix idempotency with systemd podman files (#278)
Fix #276
Label 'podman_systemd_unit' is the marker for container starting
from systemd generated file. In this case:
* Ignore podman_systemd_unit label
* Ignore cidfile settings when this label presents
2021-08-02 12:59:43 +03:00
Sergey
9ff36649ab
Change present state to be as created state (#263)
For being more compliant with docker module.
See #257
2021-07-07 18:48:50 +03:00
Sergey
8ada1501f6
Disable no-hosts idempotency (#273)
Because of podman bug we can't discover what's --no-hosts option
set to.
2021-07-07 12:11:13 +03:00
Sergey
bcdaa9f825
Add support for timezones in containers (#262)
* Remove choices for cgroups

* Add timezone parameter to container module
2021-05-24 11:39:08 +03:00
Sergey
a7629a89db
Fix multi-containers options (#258) 2021-05-24 09:58:33 +03:00
Sergey
b3cf53e5ac
Fix idempotency for environment (#260) 2021-05-24 01:22:32 +03:00
Sergey
b62fb99bae
Fix ansible-test issues for CI (#241) 2021-04-07 10:21:08 +03:00
Sergey
607c120f94
Fix uppercase labels idempotency issue (#230)
When we lower cases for all keys, but leave it original case for
all values, we need to do the same with input labels.
Add test.
Fix #227
2021-04-01 16:33:27 +03:00
Sergey
d87777394b
Add IPv6 support for publishing ports (#226) 2021-03-31 18:28:46 +03:00
Sergey
ed3a3dc080
Fix no_log for newer ansible-test (#221) 2021-03-16 16:28:58 +02:00
Andreas Gerstmayr
303486c52c
Add sigrtmin+3 signal (required for systemd containers) (#220) 2021-03-13 12:30:13 +02:00
Elias Norrby
4da30fd3fd
Attempt graceful stop when recreating container (#203)
References: containers/ansible-podman-collections#202

Co-authored-by: Sergey <sshnaidm@users.noreply.github.com>
2021-02-24 13:19:37 +02:00
Sergey
c4ba85f73c
Fixes for podman_container for Podman v3 (#209)
Fix logs, networks, etc.
2021-02-24 07:52:30 +02:00
Sergey
86c9066771
Fix idempotency for multiple ports (#194) 2021-02-14 09:47:32 +02:00
Sagi Shnaidman
8a61f88d66 Don't recreate container if env_file is specified
Fix #178
2021-02-11 04:34:25 +02:00
Sagi Shnaidman
596aab757f Fix pylint issues for ansible-test 2021-02-11 04:22:04 +02:00
Sagi Shnaidman
2b073c6e89 Fix slirp4netns options idempotency
Fix #184
2021-02-11 01:54:42 +02:00
Sagi Shnaidman
0bdaa4a78f Fix ambigous variable issue for pylint 2021-02-10 20:54:00 +02:00
Sagi Shnaidman
e4f5a8eabe Convert systemd option to a string
And set it to lower to workaround bugs in 3.0.1
2021-02-10 20:14:03 +02:00
Sagi Shnaidman
885af0c7c5 Change default log level for 3+ versions 2021-02-10 18:13:39 +02:00
Georgi Valkov
b911939f07 Fix 'cap_add' and 'cap_drop' idempotency
- Ensure that comparison always happens on lower-case values.

- Take into account that capabilities can be specified with or
  without the 'CAP_' prefix.
2021-02-01 11:24:14 +02:00
Justin Riley
db09d8e778 podman_container_lib: fix command idempotency
preserve case sensitivity by removing the use of lower() and using shlex
to split the command string
2021-01-12 13:38:28 +02:00
Sagi Shnaidman
c60f2c6cae Restart container in a simple manner
Don't require an image when restarting container, only the
container name.
2021-01-08 00:56:42 +02:00
Sagi Shnaidman
33c7fa5842 Add 'created' state for podman_container
Add state 'created' which will ensure container exists in current
configuration. It can either run or not.
2021-01-06 15:20:16 +02:00