1
0
Fork 0
mirror of https://github.com/containers/ansible-podman-collections.git synced 2026-04-01 07:16:14 +00:00
Commit graph

84 commits

Author SHA1 Message Date
Sergey
a90c040239
Fix expanduser in path for systemd generation (#510)
Use expanduser for path calculation.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2133207
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-11-11 11:00:47 +02:00
Sergey
5c68ee09fe
Add protection for systemd files deletion (#509)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-11-10 21:06:55 +02:00
Sergey
5198b726fb
Delete systemd files when container/pod is deleted (#508)
Fix #489

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-11-10 17:13:45 +02:00
antonc42
c9008c75b4
fix pod running status for older podman versions (#500)
* fix pod running status for older podman versions

Older podman versions, such as podman 1.6.4 on CentOS 7, do not have the
pod status in the 'podman pod inspect' output. Added an attribute and a
method to PodmanPod to fetch the 'podman pod ps' output. Added an
additional status check to the exising running property that uses the
'ps' info.

Fixes #499

Signed-off-by: antonc42 <antonc42@users.noreply.github.com>
2022-10-29 15:59:20 +03:00
Sergey
bf67c7e078
Improve idempotency for devices mount of rootless podman (#487)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-28 12:39:15 +03:00
Sergey
853d3a8cc7
Fix idempotency for labels in pods (#482)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-20 12:12:17 +03:00
Sergey
93b5acbf6e
Support passing multiple networks with params (#472)
Fix #467
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-03 10:40:48 +03:00
dada513
b72a026328
generate_systemd: implement --wants, --after and --requires (GH-431) (#432)
* generate_systemd: implement --wants, --after and --requires (GH-431)

Signed-off-by: dada513 <dada513@protonmail.com>
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
Co-authored-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-09-01 20:28:07 +03:00
Sergey
cecb29222e
Add --sdnotify option for container (#465)
Fix #464

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-08-28 16:42:31 +03:00
Nikita Tokarchuk
9068baeb99
podman_container should ensure image by using os path if rootfs is used (#458)
* Check image with os path if rootfs is used

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Take into account rootfs usage while evaluating a diff

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Always compare rootfs image diffparam as strict

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Reverse image labels getter to ignore the value if None

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

* Add tests to check podman rootfs containers

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>

Signed-off-by: Nikita Tokarchuk <nikita@tokarch.uk>
2022-08-12 06:26:16 +03:00
Adrian Freund
99c2851341
Fix rerunning playbooks with generate_systemd --new (#453)
* Fix restarting containers if --rm is enabled
* Automatically enable rm if generate_systemd.new is set
* Don't assume that the 'new' key in generate_systemd exists

Signed-off-by: Adrian Freund <adrian@freund.io>
2022-07-22 17:41:21 +03:00
Sergey
db27c68ef9
Fix pod tests in CI (#445)
Remove 'net' from pod idempotency if it's not in inspection.
Probably a bug on Ubuntu.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-07-04 15:46:35 +03:00
Sagi Shnaidman
75198ae574 Fix pod network idempotency
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-07-01 10:23:12 +03:00
Rabi Mishra
6dc481ae2c
Change IpcMode default to shareable (#444)
podman 4.1.x has changed the ipc namespace mode default to
shareable[1] that results in containers being restarted.

[1] 3987c529f4

Resolves: rhbz#2101495
Signed-off-by: Rabi Mishra <ramishra@redhat.com>
2022-06-29 03:10:45 +03:00
Sergey
2577f5b0f5
Remove distutils as deprecated (#437)
Fix #422
The distutils package is deprecated and slated for removal in Python 3.12

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-06-12 22:54:03 +03:00
Sergey
848034096c
Disable memory idempotency (#420)
Because of complexity in Podman logic and calculations of b/m/g
etc let's disable this idempotency for now.
Fix #418

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-04-28 00:26:28 +03:00
Sergey
e5d6136694
Change network attribute from str to list in pods #414 #416 (#417)
* Change network attribute from str to list in pods

Signed-off-by: André Cirne <dumahk21@gmail.com>

* Fix tests

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>

Co-authored-by: André Cirne <dumahk21@gmail.com>
2022-04-25 02:15:29 +03:00
Sergey
fefc7e461f
Remove idempotency for log level (#404)
Since Podman changes its defaults very often and it's impossible
to track and identify every time what is current log level, let's
remove idempotency for this parameter for now.

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-29 14:15:16 +03:00
Sergey
aa4c3223d2
Fix podman collection for Podman version 4 (#398)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-17 21:56:19 +02:00
Rubik's Dot
d024e91216
fix check for read-only change of root image (#393)
The --read-only option is not checked for changes between runs of
ansible thus the container is not recreated if the user changes
the root image between read-write to read-only.

Default for the read_only variable set to False in line with
documentation and so that later checks are simplified.

This is a fix for bug #383.

Signed-off-by: Andrew <rubiksdot@grue.cc>

Co-authored-by: Andrew <rubiksdot@grue.cc>
2022-03-14 12:54:12 +02:00
Sergey
81f20befb2
Fix error with exitcommand for Podman v4 (#390)
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-03-11 12:13:36 +02:00
Sergey
081ac5f851
Fix MAC address detection in created container (#377)
Fix #373

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 20:17:57 +02:00
Sergey
527ccacf01
Add --requires option (#378)
Fix #374
Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 18:53:37 +02:00
Sergey
23fde625f6
Strip slashes from volumes (#379)
Fix #372

Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>
2022-02-17 18:29:51 +02:00
Sergey
547abfea53
Add slirp4netns idempotency for pods (#369)
Fix #367
2022-01-16 23:44:08 +02:00
Sergey
4f3a84f4e5
Add new options for pod module (#361) 2022-01-13 15:10:05 +02:00
Timo Tomasini
9860b78ce5
Fix podman_pod_lib behavior for ports published to multiple IPs (#359)
* Fix podman_pod_lib behavior for ports published to multiple IPs

* Fix IPv6 behavior for pods and add tests

* Fix bind: cannot assign requested address issue with test container
2022-01-03 08:24:51 +02:00
Sergey
d5e52d813f
Don't include shared 'net' if network is host in pods (#348) 2021-11-29 00:04:53 +02:00
Sergey
5db058ac67
Remove default value of log-driver (#340)
The default value of log-driver is not defined now and can change
depending on the platform.
2021-11-25 19:06:02 +02:00
Oliver Walsh
f3e95d0d3f
Hardcode RT signal numbers (#338)
Looking up SIGRTMIN/SIGRTMAX isn't portable.
Hardcode the Linux signal number instead.

Fixes issue #337.
2021-11-20 03:06:07 +02:00
Luca Beltrame
cef7bdbea0
Support --new in generate_systemd (#334)
* Support --new in generate_systemd

Fixes #318.

* Add docs
2021-11-18 14:35:42 +02:00
Cédric Jeanneret
a8e81193f4
Allow to actually pass a list of string for "mounts" (#332)
Like "volume", "mount" can be passed multiple times to the container
creation/run, therefore we want to support a list of string, and a
"mounts" alias.
2021-11-09 13:40:40 +02:00
Oliver Walsh
a0377fbd24
Fix signal diff for truncated and RT signal names (#326)
* Fix signal diff for truncated and RT signal names

This refactors the signal mapping logic to closely resemble the logic in
podman.

Podman tolerates images with truncated STOPSIGNAL names e.g RTMIN+3
is used in the freeipa-container Dockerfiles.

Also avoids hardcoding real-time signals as they vary per
platform or glibc implementation (see man 7 signal).

* Cleanup lint

* More lint cleanup
2021-10-19 17:18:22 +03:00
Sergey
717963d66d
Fix issue with podman and exposed ports (#323) 2021-10-12 02:18:08 +03:00
Sergey
a1aec061f5
Support empty stings in prefixes (#321) 2021-10-11 23:38:58 +03:00
Jad Kik
15cd7623af
Add support for network-alias flag (#314)
* Add support for network-alias flag
* Ignore idempotency assert in tests

Co-authored-by: Sagi Shnaidman <sshnaidm@redhat.com>
2021-10-03 22:18:31 +03:00
Sergey
3f3cdab506
Add .service extension to systemd files (#310) 2021-09-23 09:50:16 +03:00
Sergey
5d37e1ee22
Add systemd generation for pods (#299) 2021-09-15 02:44:06 +03:00
Sergey
24329ce5d3
Generate systemd service files for containers (#298) 2021-09-13 17:13:15 +03:00
Sergey
53338e7ec0
Add podman import/export containers modules (#297) 2021-09-12 17:01:38 +03:00
Marcin Skarbek
af7772db77
Add support for podman pod create --infra-name (#292) 2021-09-01 13:42:05 +03:00
Sergey
afe55dd277
Fix idempotency when containers have a common network (#279)
Fix #252
2021-08-16 14:28:57 +03:00
Sergey
1f28b52242
Fix modules for newest pylint in ansible-test (#286) 2021-08-15 19:40:07 +03:00
Aliaksandr Mianzhynski
e9ace7b4bf
Add initial secrets support (#284)
* Add initial secrets support
2021-08-10 15:35:48 +03:00
Sergey
ed681ef10e
Fix idempotency with systemd podman files (#278)
Fix #276
Label 'podman_systemd_unit' is the marker for container starting
from systemd generated file. In this case:
* Ignore podman_systemd_unit label
* Ignore cidfile settings when this label presents
2021-08-02 12:59:43 +03:00
Sergey
9ff36649ab
Change present state to be as created state (#263)
For being more compliant with docker module.
See #257
2021-07-07 18:48:50 +03:00
Sergey
8ada1501f6
Disable no-hosts idempotency (#273)
Because of podman bug we can't discover what's --no-hosts option
set to.
2021-07-07 12:11:13 +03:00
Sergey
bcdaa9f825
Add support for timezones in containers (#262)
* Remove choices for cgroups

* Add timezone parameter to container module
2021-05-24 11:39:08 +03:00
Sergey
a7629a89db
Fix multi-containers options (#258) 2021-05-24 09:58:33 +03:00
Sergey
b3cf53e5ac
Fix idempotency for environment (#260) 2021-05-24 01:22:32 +03:00