From f4b57ac265cf43ed7f694569fd980545619c5f4d Mon Sep 17 00:00:00 2001 From: Sergey <6213510+sshnaidm@users.noreply.github.com> Date: Mon, 18 Aug 2025 22:51:19 +0300 Subject: [PATCH] Remove quiet mode from pulling image (#968) Fix #966 Signed-off-by: Sagi Shnaidman --- .github/workflows/podman_image.yml | 2 ++ .github/workflows/podman_image_info.yml | 2 ++ plugins/module_utils/podman/podman_image_lib.py | 4 ++-- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/podman_image.yml b/.github/workflows/podman_image.yml index feff729..a21a03a 100644 --- a/.github/workflows/podman_image.yml +++ b/.github/workflows/podman_image.yml @@ -11,6 +11,7 @@ on: - 'plugins/modules/podman_image.py' - 'plugins/modules/podman_image_info.py' - 'plugins/module_utils/podman/quadlet.py' + - 'plugins/module_utils/podman/podman_image_lib.py' - 'tests/integration/targets/podman_image/**' branches: - main @@ -24,6 +25,7 @@ on: - 'plugins/modules/podman_image.py' - 'plugins/modules/podman_image_info.py' - 'plugins/module_utils/podman/quadlet.py' + - 'plugins/module_utils/podman/podman_image_lib.py' - 'tests/integration/targets/podman_image/**' schedule: - cron: 4 0 * * * # Run daily at 0:03 UTC diff --git a/.github/workflows/podman_image_info.yml b/.github/workflows/podman_image_info.yml index 5d39e3c..9b5105c 100644 --- a/.github/workflows/podman_image_info.yml +++ b/.github/workflows/podman_image_info.yml @@ -10,6 +10,7 @@ on: - 'ci/playbooks/containers/podman_image_info.yml' - 'plugins/modules/podman_image.py' - 'plugins/modules/podman_image_info.py' + - 'plugins/module_utils/podman/podman_image_lib.py' - 'tests/integration/targets/podman_image_info/**' branches: - main @@ -22,6 +23,7 @@ on: - 'ci/playbooks/containers/podman_image_info.yml' - 'plugins/modules/podman_image.py' - 'plugins/modules/podman_image_info.py' + - 'plugins/module_utils/podman/podman_image_lib.py' - 'tests/integration/targets/podman_image_info/**' schedule: - cron: 4 0 * * * # Run daily at 0:03 UTC diff --git a/plugins/module_utils/podman/podman_image_lib.py b/plugins/module_utils/podman/podman_image_lib.py index 35c1616..ddb9db9 100644 --- a/plugins/module_utils/podman/podman_image_lib.py +++ b/plugins/module_utils/podman/podman_image_lib.py @@ -270,7 +270,7 @@ class PodmanImagePuller: def pull_image(self, image_name, arch=None, pull_extra_args=None): """Pull an image from a registry.""" - args = ["pull", image_name, "-q"] + args = ["pull", image_name] if arch: args.extend(["--arch", arch]) @@ -285,7 +285,7 @@ class PodmanImagePuller: rc, out, err = run_podman_command(self.module, self.executable, args, ignore_errors=True) if rc != 0: - self.module.fail_json(msg=f"Failed to pull image {image_name}: {err}") + self.module.fail_json(msg=f"Failed to pull image {image_name}", stderr=err, stdout=out) return out.strip(), podman_command