From eab26e5ebae4839d79b360c0fa976e0b2d817a1f Mon Sep 17 00:00:00 2001 From: Andreas Seidl Date: Thu, 11 Jan 2024 13:13:32 +0100 Subject: [PATCH] Fix idempotency for podman_network (#699) (#700) * Fix idempotency for podman_network when explicitly definining disable_dns parameter for Podman driver other than type bridge Signed-off-by: andreas.seidl --- plugins/modules/podman_network.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/plugins/modules/podman_network.py b/plugins/modules/podman_network.py index e702fea..3f52af4 100644 --- a/plugins/modules/podman_network.py +++ b/plugins/modules/podman_network.py @@ -348,11 +348,7 @@ class PodmanNetworkDiff: def diffparam_disable_dns(self): # For v3 it's impossible to find out DNS settings. if LooseVersion(self.version) >= LooseVersion('4.0.0'): - if self.info.get('driver') == 'bridge': - before = not self.info.get('dns_enabled', True) - # for all other drivers except bridge DNS is disabled by default - else: - before = False + before = not self.info.get('dns_enabled', True) after = self.params['disable_dns'] # compare only if set explicitly if self.params['disable_dns'] is None: