actions/setup-ssh-client
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: enhance mktemp usage for cross-platform compatibility in SSH wrapper creation

Browse source
This commit is contained in:
Karolis2011 2025-11-20 01:06:47 +02:00
parent 0338e73fcc
commit 6f6f64807e
1 changed files with 24 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

26
action.yml
View file

@ -155,9 +155,31 @@ runs:
# the wrapper in the `GITHUB_WORKSPACE` to avoid polluting repo files. # the wrapper in the `GITHUB_WORKSPACE` to avoid polluting repo files.
# Prefer runner-specific temp folders (RUNNER_TEMP), then /tmp. # Prefer runner-specific temp folders (RUNNER_TEMP), then /tmp.
TEMP_DIR="${RUNNER_TEMP:-/tmp}" TEMP_DIR="${RUNNER_TEMP:-/tmp}"
WRAPPER_DIR=$(mktemp -d "$TEMP_DIR/setup-ssh-client-XXXXXX") # Create temporary directory. mktemp implementation differs between
# Linux (GNU coreutils) and macOS (BSD). Use common-fallback patterns
# to be portable across runners.
if WRAPPER_DIR=$(mktemp -d "$TEMP_DIR/setup-ssh-client-XXXXXX" 2>/dev/null); then
:
elif WRAPPER_DIR=$(mktemp -d -p "$TEMP_DIR" setup-ssh-client-XXXXXX 2>/dev/null); then
:
else
WRAPPER_DIR="$TEMP_DIR/setup-ssh-client-$(date +%s)-$$"
mkdir -p "$WRAPPER_DIR"
fi
mkdir -p "$WRAPPER_DIR" mkdir -p "$WRAPPER_DIR"
WRAPPER_PATH="${mktemp "$WRAPPER_DIR/ssh-remote-shell-XXXXXX.sh"}" # Use command substitution $(...) — earlier use of ${...} is invalid and
# caused a "bad substitution" error in POSIX shells. `mktemp` accepts a
# template including a directory, but options differ between GNU and BSD
# implementations. Use template first, and fall back to -p for macOS.
if WRAPPER_PATH=$(mktemp "$WRAPPER_DIR/ssh-remote-shell-XXXXXX.sh" 2>/dev/null); then
: # created by GNU extension or compatible mktemp
elif WRAPPER_PATH=$(mktemp -p "$WRAPPER_DIR" ssh-remote-shell-XXXXXX.sh 2>/dev/null); then
: # fallback for BSD mktemp on macOS
else
# Last resort: generate a safe filename and create it
WRAPPER_PATH="$WRAPPER_DIR/ssh-remote-shell-$(date +%s)-$$.sh"
: > "$WRAPPER_PATH"
fi
cat << 'WRAPPER_EOF' > "$WRAPPER_PATH" cat << 'WRAPPER_EOF' > "$WRAPPER_PATH"
#!/bin/bash #!/bin/bash